Upgrade cluster_tools to v1.0.8 in shard.yml #2200
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge till the new cluster_tools version is published (See cnf-testsuite/cluster_tools#29) |
|
@collivier the reason for GH actions failure is that you need to transitively change the cluster_tools to your version in all the shards and make that a part of your pull request (purely for the purposes of testing). This is quite a painful process. |
|
@svteb yes. Thank you. I'm on it now. |
It includes the fix stopping passing stdin to the container. Signed-off-by: Cédric Ollivier <[email protected]>
collivier
force-pushed
the
upgrade_cluster_tools
branch
from
74d1f05 to
b1dcc93
Compare
|
Please wait the upstream change and then I will slightly update this one |
martin-mat
requested changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It includes the fix stopping passing stdin to the container.
How has this been tested: